Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial person info to cookie when using localPlusCookieStore #1559

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Nov 26, 2024

Changes

Fixes #1524 by moving the initial person info to the cookie

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 27, 2024 10:51am

@robbie-c robbie-c changed the title feat: Add initial person info to cookie storage feat: Add initial person info to cookie when using localPlusCookieStorage Nov 26, 2024
@robbie-c robbie-c changed the title feat: Add initial person info to cookie when using localPlusCookieStorage feat: Add initial person info to cookie when using localPlusCookieStore Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Size Change: +404 B (+0.01%)

Total Size: 3.17 MB

Filename Size Change
dist/array.full.es5.js 257 kB +37 B (+0.01%)
dist/array.full.js 360 kB +37 B (+0.01%)
dist/array.full.no-external.js 359 kB +37 B (+0.01%)
dist/array.js 174 kB +37 B (+0.02%)
dist/array.no-external.js 173 kB +37 B (+0.02%)
dist/customizations.full.js 12.2 kB +34 B (+0.28%)
dist/main.js 175 kB +37 B (+0.02%)
dist/module.full.js 360 kB +37 B (+0.01%)
dist/module.full.no-external.js 359 kB +37 B (+0.01%)
dist/module.js 175 kB +37 B (+0.02%)
dist/module.no-external.js 173 kB +37 B (+0.02%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@robbie-c robbie-c force-pushed the feature/move-initial-person-info-to-cookie branch from d7975b5 to 6867497 Compare November 27, 2024 10:43
@robbie-c robbie-c merged commit 2de8e16 into main Nov 27, 2024
13 checks passed
@robbie-c robbie-c deleted the feature/move-initial-person-info-to-cookie branch November 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
2 participants