Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys): add configurable delay to popup surveys #1228

Merged
merged 27 commits into from
Jun 24, 2024
Merged

feat(surveys): add configurable delay to popup surveys #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b395861
this works a treat
dmarticus Jun 6, 2024
b252c5b
this works without looping survey send events
dmarticus Jun 6, 2024
c0067bc
some conversion magic
dmarticus Jun 6, 2024
852f539
okay so this appears to work now
dmarticus Jun 6, 2024
57c47cb
oops, don't need this
dmarticus Jun 6, 2024
bd6e9c0
added better testing, woohoo
dmarticus Jun 7, 2024
8f97d73
this WORKS
dmarticus Jun 10, 2024
86ed4db
confirmed that this works for my use case
dmarticus Jun 11, 2024
ff23a5f
this works for all the use cases
dmarticus Jun 11, 2024
0959171
bring the comments back
dmarticus Jun 12, 2024
9b3be21
more docs, more tests
dmarticus Jun 13, 2024
12516b9
reference refactor in comment
dmarticus Jun 13, 2024
2762293
tests aren't ready
dmarticus Jun 13, 2024
b8f84ae
one more thing
dmarticus Jun 13, 2024
abee24c
Merge branch 'main' into feat/delay-survey-popup
dmarticus Jun 13, 2024
6d01cf5
Merge branch 'main' into feat/delay-survey-popup
dmarticus Jun 18, 2024
0838062
changing a type name
dmarticus Jun 18, 2024
18d099c
added a bunch of tests for new behavior
dmarticus Jun 18, 2024
e3bd462
better docs
dmarticus Jun 18, 2024
d7bca6e
resolve merge conflicts
dmarticus Jun 18, 2024
bb5312d
Update src/__tests__/extensions/surveys.test.ts
dmarticus Jun 19, 2024
ba71533
Update src/__tests__/extensions/surveys.test.ts
dmarticus Jun 19, 2024
6be5f55
Update src/__tests__/extensions/surveys.test.ts
dmarticus Jun 19, 2024
7f68ad6
fixed the test
dmarticus Jun 20, 2024
34ab992
addressed the rest of neil's feedback
dmarticus Jun 20, 2024
3ecd876
use a string | null instead of a set
dmarticus Jun 20, 2024
547e439
merge conflict resolution
dmarticus Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
"@rrweb/types": "2.0.0-alpha.13",
"@sentry/types": "8.7.0",
"@testing-library/dom": "^9.3.0",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/preact": "^3.2.4",
"@types/eslint": "^8.44.6",
"@types/jest": "^29.5.1",
"@types/react-dom": "^18.0.10",
Expand Down
103 changes: 103 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading