fix(surveys): Handle filtering on undefined (#810)

* return early for undefined surveys * move empty array return into getSurveys * Update src/__tests__/surveys.js * fix --------- Co-authored-by: Neil Kakkar <[email protected]>
PostHog · Oct 2, 2023 · 93adf1a · 93adf1a
1 parent 471406f
commit 93adf1a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/__tests__/surveys.js b/src/__tests__/surveys.js
@@ -101,6 +101,13 @@ describe('surveys', () => {
         expect(given.instance._send_request).toHaveBeenCalledTimes(2)
     })
 
+    it('getSurveys returns empty array if surveys are undefined', () => {
+        given('surveysResponse', () => ({ status: 0 }))
+        given.surveys.getSurveys((data) => {
+            expect(data).toEqual([])
+        })
+    })
+
     describe('getActiveMatchingSurveys', () => {
         const draftSurvey = {
             name: 'draft survey',

diff --git a/src/posthog-surveys.ts b/src/posthog-surveys.ts
@@ -17,7 +17,7 @@ export class PostHogSurveys {
                 {},
                 { method: 'GET' },
                 (response) => {
-                    const surveys = response.surveys
+                    const surveys = response.surveys || []
                     this.instance.persistence?.register({ [SURVEYS]: surveys })
                     return callback(surveys)
                 }