Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(surveys): add configurable delay to popup surveys (#1228)
* this works a treat * this works without looping survey send events * some conversion magic * okay so this appears to work now * oops, don't need this * added better testing, woohoo * this WORKS * confirmed that this works for my use case * this works for all the use cases * bring the comments back * more docs, more tests * reference refactor in comment * tests aren't ready * one more thing * changing a type name * added a bunch of tests for new behavior * better docs * Update src/__tests__/extensions/surveys.test.ts Co-authored-by: Neil Kakkar <[email protected]> * Update src/__tests__/extensions/surveys.test.ts Co-authored-by: Neil Kakkar <[email protected]> * Update src/__tests__/extensions/surveys.test.ts Co-authored-by: Neil Kakkar <[email protected]> * fixed the test * addressed the rest of neil's feedback * use a string | null instead of a set --------- Co-authored-by: Neil Kakkar <[email protected]>
- Loading branch information