Skip to content

Commit

Permalink
feat(surveys): add configurable delay to popup surveys (#1228)
Browse files Browse the repository at this point in the history
* this works a treat

* this works without looping survey send events

* some conversion magic

* okay so this appears to work now

* oops, don't need this

* added better testing, woohoo

* this WORKS

* confirmed that this works for my use case

* this works for all the use cases

* bring the comments back

* more docs, more tests

* reference refactor in comment

* tests aren't ready

* one more thing

* changing a type name

* added a bunch of tests for new behavior

* better docs

* Update src/__tests__/extensions/surveys.test.ts

Co-authored-by: Neil Kakkar <[email protected]>

* Update src/__tests__/extensions/surveys.test.ts

Co-authored-by: Neil Kakkar <[email protected]>

* Update src/__tests__/extensions/surveys.test.ts

Co-authored-by: Neil Kakkar <[email protected]>

* fixed the test

* addressed the rest of neil's feedback

* use a string | null instead of a set

---------

Co-authored-by: Neil Kakkar <[email protected]>
  • Loading branch information
dmarticus and neilkakkar authored Jun 24, 2024
1 parent 3017d39 commit 2e26881
Show file tree
Hide file tree
Showing 6 changed files with 818 additions and 168 deletions.
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
"@rrweb/types": "2.0.0-alpha.13",
"@sentry/types": "8.7.0",
"@testing-library/dom": "^9.3.0",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/preact": "^3.2.4",
"@types/eslint": "^8.44.6",
"@types/jest": "^29.5.1",
"@types/react-dom": "^18.0.10",
Expand Down
103 changes: 103 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2e26881

Please sign in to comment.