Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
benjackwhite committed Dec 4, 2024
1 parent 5548ae4 commit 2cff552
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
6 changes: 0 additions & 6 deletions src/posthog-core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,6 @@ export class PostHog {
}

_onRemoteConfig(config: RemoteConfig) {
// TODO: check config. If "hasFlags" is anything other than false - load the flags from decide (later will be /flags)

this.compression = undefined
if (config.supportedCompression && !this.config.disable_compression) {
this.compression = includes(config['supportedCompression'], Compression.GZipJS)
Expand Down Expand Up @@ -576,10 +574,6 @@ export class PostHog {
this.webVitalsAutocapture?.onRemoteConfig(config)
this.exceptionObserver?.onRemoteConfig(config)
this.deadClicksAutocapture?.onRemoteConfig(config)

if (config.hasFeatureFlags !== false) {
// Check explicitly for false - anything else means we there could be so lets load them
}
}

_loaded(): void {
Expand Down
12 changes: 0 additions & 12 deletions src/site-apps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,6 @@ export class SiteApps {
}

onRemoteConfig(response?: RemoteConfig): void {
if (assignableWindow._POSTHOG_SITE_APPS) {
// Loaded via new config so we have the apps preloaded
if (this.instance.config.opt_in_site_apps) {
assignableWindow._POSTHOG_SITE_APPS.forEach((app) => {
app.load(this.instance)
})
}
this.loaded = true

return
}

if (isArray(response?.siteApps) && response.siteApps.length > 0) {
if (this.enabled && this.instance.config.opt_in_site_apps) {
const checkIfAllLoaded = () => {
Expand Down

0 comments on commit 2cff552

Please sign in to comment.