Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make Celery Queue Depth page less #794

Merged
merged 1 commit into from
Feb 12, 2024
Merged

chore: Make Celery Queue Depth page less #794

merged 1 commit into from
Feb 12, 2024

Conversation

tiina303
Copy link
Contributor

companion to https://github.com/PostHog/charts/pull/773

We've been paging for this daily for more than 10 days. In all of those cases there hasn't been any action and it resolves itself. This creates alert fatigue, so let's make the alert less sensitive. We can additionally add a non-paging alert, if this is deemed useful.

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

companion to https://github.com/PostHog/charts/pull/773

We've been paging for this daily for more than 10 days. In all of those cases there hasn't been any action and it resolves itself. This creates alert fatigue, so let's make the alert less sensitive.
We can additionally add a non-paging alert, if this is deemed useful.
@tiina303 tiina303 requested review from benjackwhite and a team February 12, 2024 14:08
@tiina303
Copy link
Contributor Author

Just to confirm ERROR test_redis_internal_with_password.py::test_redis_secret - TypeError: getfixtureclosure() missing 1 required positional argument: 'ignore_args' is a known problem and I can merge this PR?

@tiina303 tiina303 merged commit ace6018 into main Feb 12, 2024
12 of 47 checks passed
@tiina303 tiina303 deleted the tiina303-patch-2 branch February 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants