Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix worker HPA to target new worker groups #783

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Fix worker HPA to target new worker groups #783

merged 6 commits into from
Jan 17, 2024

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Jan 17, 2024

Also fix matchLabel clash between different worker deployments

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@frankh
Fix worker HPA to target new worker groups
e9ba29a 
Also fix matchLabel clash between different worker deployments
@frankh frankh requested a review from webjunkie January 17, 2024 10:20
webjunkie
webjunkie reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@webjunkie webjunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these references need to be adjusted.

charts/posthog/templates/worker-hpa.yaml Outdated Show resolved Hide resolved
charts/posthog/templates/worker-hpa.yaml Outdated Show resolved Hide resolved
charts/posthog/templates/worker-hpa.yaml Outdated Show resolved Hide resolved
@frankh
Bump version
d1fd7ce
@frankh
Swap worker naming around
106a251 
MatchLabels is immutable so easiest workaround is change the deployment names
@frankh
Fix deploy name
1928485
@frankh frankh requested a review from webjunkie January 17, 2024 11:30
@frankh frankh merged commit 0cb5186 into main Jan 17, 2024
48 checks passed
@frankh frankh deleted the frank/worker-hpa-fix branch January 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

@webjunkie webjunkie Awaiting requested review from webjunkie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankh @webjunkie @benjackwhite