Support readiness gates on web/events/recordings deployments #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankh
changed the title
xvello
approved these changes
Oct 2, 2023
This will allow us to safely use Pod ALB targets with least-conn routing
frankh
force-pushed
the
frank/readiness-gates
branch
from
6962bbb
to
72e72a3
Compare
|
closed in favour of: https://github.com/PostHog/posthog-cloud-infra/pull/2186/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add "readinessGates" to web deployments so we can use the ALB controller readiness gates: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v1.1/guide/ingress/pod-conditions/
This means during rollouts we will always ensure the new pods are in the load balancer before terminating the old pods
Type of change
How has this been tested?
The features are behind
.Valueschecks, we will roll out in dev firstChecklist