Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerts: add paging CeleryQueueDepth monitor #711

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Mar 17, 2023

Description

Add a monitor paging when Celery is getting slow and not processing jobs fast enough. No runbook yet, but I wrote basic investigation steps in the monitor description. It's not perfect as Celery is currently reporting its own health, and the metric will not be exported if Celery is completely down. We should also add a last_job_run_timestamp metric and alert on it. Or is there an easy way to alert on no-data in prometheus?

I tried to calibrate it so that:

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@xvello xvello requested a review from a team March 17, 2023 10:29
@xvello
Copy link
Contributor Author

xvello commented Mar 17, 2023

#712 is a "watching the watcher" follow-up blocked for now on infra work

@xvello xvello merged commit e13c217 into main Mar 17, 2023
@xvello xvello deleted the xvello/celery-page branch March 17, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants