Merge 2c7fb6a into 580e68a

PostHog · Jan 18, 2024 · b0d63da · b0d63da
2 parents 580e68a + 2c7fb6a
commit b0d63da
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/charts/posthog/templates/worker-hpa.yaml b/charts/posthog/templates/worker-hpa.yaml
@@ -11,8 +11,8 @@ spec:
     kind: Deployment
     apiVersion: apps/v1
     name: {{ template "posthog.fullname" $ }}-worker-{{ .name }}
-  minReplicas: {{ $.Values.worker.hpa.minpods }}
-  maxReplicas: {{ $.Values.worker.hpa.maxpods }}
+  minReplicas: {{ .hpa.minpods | default $.Values.worker.hpa.minpods  }}
+  maxReplicas: {{ .hpa.maxpods | default $.Values.worker.hpa.maxpods  }}
   metrics:
   {{- with $.Values.worker.hpa.cputhreshold }}
   - type: Resource

diff --git a/charts/posthog/tests/worker-hpa.yaml b/charts/posthog/tests/worker-hpa.yaml
@@ -79,3 +79,31 @@ tests:
             behavior:
               scaleDown:
                 stabilizationWindowSeconds: 3600
+
+  - it: respects consumer overrides
+    set:
+      worker.enabled: true
+      worker:
+        consumers:
+          - name: default
+            hpa:
+              minpods: 5
+              maxpods: 50
+        hpa:
+          enabled: true
+          minpods: 2
+          maxpods: 10
+          cputhreshold: 70
+          behavior:
+            scaleDown:
+              stabilizationWindowSeconds: 3600
+    asserts:
+      - equal:
+          path: spec
+          value:
+            scaleTargetRef:
+              apiVersion: apps/v1
+              kind: Deployment
+              name: RELEASE-NAME-posthog-worker-default
+            minReplicas: 5
+            maxReplicas: 50