-
Notifications
You must be signed in to change notification settings - Fork 41
Remove deprecated neon animation, use CSS keyframe animations #163
base: master
Are you sure you want to change the base?
Conversation
e2c339c
to
f7fa41a
Compare
Thanks for completing this for me, I have had other duties! Looking good. How about iron-dropdown etc. ? |
I have used cancel-animation in paper-tooltip.
If someone runs this function. I think that they expect it to stop animating and return to the fully shown or fully hidden. Not sure if you want this function in this component. /**
* Cancels the animation and either fully shows or fully hides tooltip
*/
cancelAnimation: function () {
// Short-cut and cancel all animations and hide
this.$.tooltip.classList.add('cancel-animation');
}, |
By removing the animation class, the component should go to the |
Re |
The cancelAnimation in paperTooltip was slightly different, the request was if it was called that whatever was left of the animation was to complete and it to be at the end of the state. Hence the -30s timing indicator. So the animation ran to the end. You can try out the final demo on paper-tooltip for an example. |
We can use the css class to start & cancel animations, eg see http://jsbin.com/ladexiz/1/edit?html,output |
I believe if I can remember the issue was that the paper-tooltip could be cancelled each way. Fade in and fade out with a opacity that was set by a mixin --paper-tooltip-opacity. You couldn't jump to the end of the animation with its final state as it is set by the animation. I think since the paper-tooltip needs the opacity value is why I did the -30s trick. |
I see. I'd be curious to see how |
d354b1a
to
f7fa41a
Compare
6c39cba
to
f7fa41a
Compare
Fixes #161, based off work started by @homerjonathan and @DudleyAH in #160
Remove the
neon-animation
dependency in favor of CSS keyframe animations.<paper-dialog>
now ships 4 animations,fade-in-animation, fade-out-animation, scale-up-animation, scale-down-animation
, and supports custom animations too.We keep the
animationConfig
property and warn that they won't be affecting the animation.We keep all the public methods previously inherited from
neon-animation-runner-behavior
, and make them no-op.This PR adds tests and addresses the feedback provided in #160