Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Enable clients to use CSS animations. #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cbelden
Copy link

@cbelden cbelden commented Jul 26, 2016

This is an idea that solves an issue we were experiencing with the paper-dialog. We found that modifying the existing animations (ie "scale-up-animation") would require either implementing our own web animation or providing some sort of global animation configuration.

Using CSS animations is an easy way for us to apply an animation to all of our paper-dialog instances, however, there was no decent way to target dialogs that are opening/closing.

This PR adds classes when the dialog is opened (or closed). This PR also resolves issue #119 (or at least provides a workaround).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@cbelden
Copy link
Author

cbelden commented Jul 26, 2016

I signed it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants