Expose border styling properties as CSS properties #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bicknellr, it appears that the Travis CI is no longer functioning properly. Is there any chance we could get this minor style update merged in and a new version number released? It would spare us from having to fork or vendor the entire component. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three border styling properties we would like to expose on
paper-checkboxfor our use case. Upon upgrading to Polymer 3 from Polymer 1, the switch from ShadyCSS to ShadowDOM broke some of our custom styling forpaper-checkbox. In this PR, we expose these properties as CSS variables and maintain the default styles as a fallback.Fixes #182, fixes #184.