Use working version of web-animations-js #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-animations-js version 2.2.3 is broken. Resolves PolymerElements#229
samuelli
reviewed
Apr 13, 2017
| @@ -34,7 +34,7 @@ | |||
| "iron-meta": "PolymerElements/iron-meta#^1.0.0", | |||
| "iron-resizable-behavior": "PolymerElements/iron-resizable-behavior#^1.0.0", | |||
| "iron-selector": "PolymerElements/iron-selector#^1.0.0", | |||
| "web-animations-js": "web-animations/web-animations-js#^2.2.0" | |||
| "web-animations-js": "web-animations/web-animations-js#2.2.2" | |||
There was a problem hiding this comment.
Why is the caret removed? ^2.2.2 is still valid.
|
Using the carat was still pulling 2.2.3
…On Apr 13, 2017 5:04 PM, "Sam Li" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bower.json
<#230 (comment)>
:
> @@ -34,7 +34,7 @@
"iron-meta": "PolymerElements/iron-meta#^1.0.0",
"iron-resizable-behavior": "PolymerElements/iron-resizable-behavior#^1.0.0",
"iron-selector": "PolymerElements/iron-selector#^1.0.0",
- "web-animations-js": "web-animations/web-animations-js#^2.2.0"
+ "web-animations-js": "web-animations/web-animations-js#2.2.2"
Why is the caret removed? ^2.2.2 is still valid.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#230 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQgI5qQdDZNwEgwSyJ1TNGX0aYf4ycp1ks5rvo3IgaJpZM4M858_>
.
|
Oh I see. Let me see if we can get web-animations fixed. |
|
Just to keep everyone in the loop. I'm trying to get this fixed upstream in web-animations. If that doesn't resolve in the next few hours, we'll go with this stop-gap solution. |
8 tasks
|
Closing this issue since it has been fixed upstream in web-animations/web-animations-js#124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-animations-js version 2.2.3 is broken.
Resolves #229