Check for scroll or auto anywhere in node style #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A valid computed style for overflow is "scroll auto". The existing implementation would consider this style a "non-scrollable" node. This change handles the edge case.
jarrodek
reviewed
Nov 20, 2019
| @@ -289,10 +289,10 @@ export function _getScrollableNodes(nodes) { | |||
| var node = /** @type {!Element} */ (nodes[i]); | |||
| // Check inline style before checking computed style. | |||
| var style = node.style; | |||
| if (style.overflow !== 'scroll' && style.overflow !== 'auto') { | |||
| if (style.overflow.includes('scroll') && style.overflow.includes('auto')) { | |||
There was a problem hiding this comment.
There should be "!" om the conditions. It should not include scroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A valid computed style for overflow is "scroll auto". The existing implementation would consider this style a "non-scrollable" node. This change handles the edge case.