Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mypy version #246

Merged
merged 8 commits into from
Aug 17, 2024
Merged

update mypy version #246

merged 8 commits into from
Aug 17, 2024

Conversation

SeanAverS
Copy link
Contributor

@SeanAverS SeanAverS commented Aug 10, 2024

What's changed

in setup.py, update mypy version to <2

What this fixes and how it's fixed

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did this pass tests locally?

setup.py Outdated Show resolved Hide resolved
@MaxGhenis
Copy link
Contributor

Please also populate changelog_entry.yaml (see other PRs)

@MaxGhenis
Copy link
Contributor

changelog_entry.yaml not changelog.yaml

@SeanAverS
Copy link
Contributor Author

@MaxGhenis thank you for your patience 🙏

@MaxGhenis
Copy link
Contributor

Please do not edit changelog (we automate that)

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please match the format of changelog_entry.yaml from other merged prs to address the CI failure

changelog_entry.yaml Outdated Show resolved Hide resolved
changelog_entry.yaml Outdated Show resolved Hide resolved
SeanAverS and others added 2 commits August 17, 2024 11:44
@MaxGhenis MaxGhenis merged commit 0bdcfaa into PolicyEngine:master Aug 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to mypy 1
2 participants