Re-enable cliff impacts #1845
Closed
Re-enable cliff impacts #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show the hover? I'm curious what we show as the baseline cliff rates. |
|
Just tried locally and getting these results. Something is off in our calculation, should be at least 1%. @nikhilwoodruff should we refactor using the new MTR code for LSRs? Baseline for 2024:
|
|
Ah, yes we should which will probably block this for at least a couple of weeks. |
|
@MaxGhenis Wanted to check if this is desired at all |
|
Could we check the numbers again? |
|
Sure, will do |
…22_to_enhanced_cps_2024 Changing from enhanced_cps_2022 to 2024
…/issue2025 Policy output info modal appears every time
…ted-runtime-has-duplicate-time-phrasing remove duplicate phrasing in estimated simulation runtime
Add UK Research Associate job posting
…e2044 Oregon Rebate post
Bumps the sub-major group with 26 updates: | Package | From | To | | --- | --- | --- | | [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) | `7.24.7` | `7.25.9` | | [@uiw/codemirror-extensions-langs](https://github.com/uiwjs/react-codemirror) | `4.23.3` | `4.23.6` | | [@uiw/codemirror-theme-github](https://github.com/uiwjs/react-codemirror) | `4.23.3` | `4.23.6` | | [@uiw/react-codemirror](https://github.com/uiwjs/react-codemirror) | `4.23.3` | `4.23.6` | | [@uiw/react-textarea-code-editor](https://github.com/uiwjs/react-textarea-code-editor) | `3.0.2` | `3.1.0` | | [antd](https://github.com/ant-design/ant-design) | `5.21.2` | `5.21.6` | | [framer-motion](https://github.com/framer/motion) | `11.9.0` | `11.11.11` | | [openai](https://github.com/openai/openai-node) | `4.66.1` | `4.69.0` | | [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) | `6.26.2` | `6.27.0` | | [workbox-background-sync](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-broadcast-update](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-cacheable-response](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-core](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-expiration](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-google-analytics](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-navigation-preload](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-precaching](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-range-requests](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-routing](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-strategies](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [workbox-streams](https://github.com/googlechrome/workbox) | `7.1.0` | `7.3.0` | | [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) | `7.25.4` | `7.26.0` | | [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) | `6.5.0` | `6.6.3` | | [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) | `29.5.13` | `29.5.14` | | [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) | `7.37.0` | `7.37.2` | | [typescript](https://github.com/microsoft/TypeScript) | `5.6.2` | `5.6.3` | Updates `@babel/preset-react` from 7.24.7 to 7.25.9 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.25.9/packages/babel-preset-react) Updates `@uiw/codemirror-extensions-langs` from 4.23.3 to 4.23.6 - [Release notes](https://github.com/uiwjs/react-codemirror/releases) - [Commits](uiwjs/react-codemirror@v4.23.3...v4.23.6) Updates `@uiw/codemirror-theme-github` from 4.23.3 to 4.23.6 - [Release notes](https://github.com/uiwjs/react-codemirror/releases) - [Commits](uiwjs/react-codemirror@v4.23.3...v4.23.6) Updates `@uiw/react-codemirror` from 4.23.3 to 4.23.6 - [Release notes](https://github.com/uiwjs/react-codemirror/releases) - [Commits](uiwjs/react-codemirror@v4.23.3...v4.23.6) Updates `@uiw/react-textarea-code-editor` from 3.0.2 to 3.1.0 - [Release notes](https://github.com/uiwjs/react-textarea-code-editor/releases) - [Commits](uiwjs/react-textarea-code-editor@v3.0.2...v3.1.0) Updates `antd` from 5.21.2 to 5.21.6 - [Release notes](https://github.com/ant-design/ant-design/releases) - [Changelog](https://github.com/ant-design/ant-design/blob/master/CHANGELOG.en-US.md) - [Commits](ant-design/ant-design@5.21.2...5.21.6) Updates `framer-motion` from 11.9.0 to 11.11.11 - [Changelog](https://github.com/framer/motion/blob/main/CHANGELOG.md) - [Commits](motiondivision/motion@v11.9.0...v11.11.11) Updates `openai` from 4.66.1 to 4.69.0 - [Release notes](https://github.com/openai/openai-node/releases) - [Changelog](https://github.com/openai/openai-node/blob/master/CHANGELOG.md) - [Commits](openai/openai-node@v4.66.1...v4.69.0) Updates `react-router-dom` from 6.26.2 to 6.27.0 - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/[email protected]/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/[email protected]/packages/react-router-dom) Updates `workbox-background-sync` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-broadcast-update` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-cacheable-response` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-core` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-expiration` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-google-analytics` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-navigation-preload` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-precaching` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-range-requests` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-routing` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-strategies` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `workbox-streams` from 7.1.0 to 7.3.0 - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.1.0...v7.3.0) Updates `@babel/preset-env` from 7.25.4 to 7.26.0 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.0/packages/babel-preset-env) Updates `@testing-library/jest-dom` from 6.5.0 to 6.6.3 - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.5.0...v6.6.3) Updates `@types/jest` from 29.5.13 to 29.5.14 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Updates `eslint-plugin-react` from 7.37.0 to 7.37.2 - [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.37.0...v7.37.2) Updates `typescript` from 5.6.2 to 5.6.3 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.6.2...v5.6.3) --- updated-dependencies: - dependency-name: "@babel/preset-react" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: "@uiw/codemirror-extensions-langs" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: sub-major - dependency-name: "@uiw/codemirror-theme-github" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: sub-major - dependency-name: "@uiw/react-codemirror" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: sub-major - dependency-name: "@uiw/react-textarea-code-editor" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: antd dependency-type: direct:production update-type: version-update:semver-patch dependency-group: sub-major - dependency-name: framer-motion dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: openai dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-background-sync dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-broadcast-update dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-cacheable-response dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-core dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-expiration dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-google-analytics dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-navigation-preload dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-precaching dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-range-requests dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-routing dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-strategies dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: workbox-streams dependency-type: direct:production update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: "@testing-library/jest-dom" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sub-major - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: sub-major - dependency-name: eslint-plugin-react dependency-type: direct:development update-type: version-update:semver-patch dependency-group: sub-major - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch dependency-group: sub-major ... Signed-off-by: dependabot[bot] <[email protected]>
…_and_yarn/sub-major-de7d6ed86e chore(deps): bump the sub-major group with 26 updates
Upgrade to Node v22
…e2187 2024 US presidential election calculator post
…e#2178) * fix: Repair wrappedJsonStringify, modify reformDefinitionCode * chore: Lint
…dget-banner UK autumn budget banner
…e2193 Add current law CTC calculator
* Capital-Gains-Tax-post * fixing style
…icle-banner Add capital gains article to home banner
…yles-wrapper-in-ant-drawer Remove deprecated prop in antd Drawer
…olk/policyengine-app into fix/1843-re-enable-cliffs
|
@MaxGhenis Just attempted to re-run cliff impacts using these changes and our prod API, but I'm just getting a spinner. I'm guessing there's an issue in the API-side implementation. |
|
This PR is so old that rebasing caused the above issue. I'll close this and open a new one, especially considering that this will probably require API-side changes, anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1843.
Fixes #1844.
Changes
This PR re-enables cliff impacts and removes the hanging semicolon present due to a syntax error in
PolicyOutput.jsx.Screenshots
AwesomeScreenshot-5_31_2024.7.49.51PM.mp4
Tests
N/A