Remove duplicate route for /simulations (#1952) #1955
Conversation
There was a problem hiding this comment.
Thanks for your work on this @mikesmit! Unfortunately, this change causes tests to fail; could you look into why that is? If you're unable to, I could also do so, just give me the word.
Also, please open an issue in the repo for this, then begin your top comment with "Fixes #ISSUE NUMBER". This helps us better track changes.
changelog_entry.yaml
Outdated
| @@ -0,0 +1,4 @@ | |||
| bump: patch | |||
There was a problem hiding this comment.
| bump: patch | |
| - bump: patch |
This is required due to how this file's parsed by yaml-changelog
There was a problem hiding this comment.
Question: I was going to write that in the commit title ("FIXES #issue") , but I looked at your commit log and the convention seemed to actually be "thing I did (#issue)" (for instance Fix error debugging (https://github.com/PolicyEngine/policyengine-api/pull/1943) which was why I wrote the commit message that way (intended to reference #1952)
Is there some automation that replaces the title and/or am I misunderstanding what you are asking for there?
There was a problem hiding this comment.
With regard to the tests... I can't actually run them locally at all at the moment because of this issue although that is failing with a different root cause. I'll eyeball the logs and see what I can see though.
There was a problem hiding this comment.
Right, I did see your comment in Slack on #1954. Weirdly, I tried responding last night, but my message doesn't appear as of today, though I see Nikhil ended up giving some context. If nothing becomes apparent, feel free to let me know. I can run locally and see if I can figure out what's going on.
Fixes #1952 The flask app defines the same GET operation on /simulations twice. This change simply removes one of them.
mikesmit
force-pushed
the
1952-remove-duplicate-routes
branch
from
105bff1
to
27f09ce
Compare
|
And of course for some reason, the tests passed upon your force push. Maybe the failure was either a fluke or old code. Thanks for this @mikesmit, approving. |
The flask app defines the same GET operation on /simulations twice. This change simply removes one of them.