Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shuffle results messaging #314

Merged
merged 8 commits into from
May 30, 2024
Merged

shuffle results messaging #314

merged 8 commits into from
May 30, 2024

Conversation

josh-chamberlain
Copy link
Contributor

fixes #294

now, this note about making a request will always show, regardless how many results appear. before, it wasn't showing when there were 0 results.

Screen Shot 2024-05-30 at 3 46 21 PM

@josh-chamberlain
Copy link
Contributor Author

@joshuagraber I ran npx vitest -u to get this snapshot updated, not sure if that's what I should have done but it looks ok?

@joshuagraber
Copy link
Contributor

@joshuagraber I ran npx vitest -u to get this snapshot updated, not sure if that's what I should have done but it looks ok?

Hey @josh-chamberlain that's exactly right. You can also run npm run test -- -u, since we have a test script defined in package.json.

@josh-chamberlain josh-chamberlain merged commit 95c610d into main May 30, 2024
10 checks passed
@josh-chamberlain josh-chamberlain deleted the results-messaging branch May 30, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuagraber joshuagraber joshuagraber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show "make a request" link on 0 results
2 participants
@josh-chamberlain @joshuagraber