Merge pull request #26 from Police-Data-Accessibility-Project/mc_issu…

…e_312_replace_http_status_code_when_source_not_found ⚙️ Adjust status code for data source not found response
Police-Data-Accessibility-Project · Jun 2, 2024 · 144d4ac · 144d4ac
2 parents f1e47c6 + 4e85a2b
commit 144d4ac
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/middleware/data_source_queries.py b/middleware/data_source_queries.py
@@ -110,7 +110,7 @@ def data_source_by_id_wrapper(arg, conn: PgConnection) -> Response:
         return make_response(data_source_details, 200)
 
     else:
-        return make_response({"message": "Data source not found."}, 404)
+        return make_response({"message": "Data source not found."}, 200)
 
 
 def get_data_sources_for_map_wrapper(conn: PgConnection):

diff --git a/tests/middleware/test_data_source_queries.py b/tests/middleware/test_data_source_queries.py
@@ -188,4 +188,4 @@ def test_data_source_by_id_wrapper_data_not_found(mock_data_source_by_id_query,
     mock_data_source_by_id_query.assert_called_with(
         data_source_id="SOURCE_UID_1", conn=mock_conn
     )
-    mock_make_response.assert_called_with({"message": "Data source not found."}, 404)
+    mock_make_response.assert_called_with({"message": "Data source not found."}, 200)