Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mc fix archives bug #19

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Mc fix archives bug #19

merged 3 commits into from
Jun 25, 2024

Conversation

maxachis
Copy link
Contributor

Fixes

  • None. Bug fixes and QoL improvements.

Description

  • Fixed bugs preventing Automatic Archives from Automatically Archiving.
  • Refactored code to be generally more comprehensible.
  • Added enhancements to improve visibility of actions in console.
  • Removed the process whereby multiple workers (up to 100) were archiving data in parallel. Because the internet archives will temporarily block an IP address if more than 15 requests are made within a minute, additional workers do not improve performance and merely add complexity.

Testing

  • Run cache_url.py with necessary environment variables.

Performance

  • Some additional overhead due to refactoring
  • Jobs will take longer, in part because archive action must be throttled to prevent internet archive from temporarily blocking the IP address.

Docs

  • Not applicable.

@josh-chamberlain josh-chamberlain merged commit f2a7d46 into main Jun 25, 2024
1 check passed
@josh-chamberlain josh-chamberlain deleted the mc_fix_archives_bug branch June 25, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants