Integrate LuckShiba's timezone command #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flicksie
reviewed
Oct 12, 2021
Flicksie
reviewed
Oct 12, 2021
core/commands/utility/timezone.js
Outdated
| const tz = ct.lookupViaCity(zoneName)[0]?.timezone || m.tz.zone(zoneName)?.name; | ||
|
|
||
| if (!tz) { | ||
| msg.channel.send("Couldn't find that place."); |
There was a problem hiding this comment.
Cloudy command feedback. first-time usage tests were a bit clueless
Flicksie
reviewed
Oct 12, 2021
Flicksie
reviewed
Oct 12, 2021
Flicksie
requested changes
Oct 12, 2021
There was a problem hiding this comment.
Check inline comments.
Main points are:
- Improve UX / Response design (blind attempts to use the command return unclear instructions, intuitive usage yields no results)
- [Minor] Consider the possibility of not using new dependencies for the task.
- Moment is deprecated internally. Use
Intl.DateTimeFormatordate-fnsinstead
Updating PR branch (in favor of package.json)
Also improved TZ search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONSEGUI FAZER ESSA BOSTA