-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing special encounters gens 3-5 #1189
base: master
Are you sure you want to change the base?
Add missing special encounters gens 3-5 #1189
Conversation
Added missing special encounters (mostly static overworld pokemon) along with corresponding missing location, location areas, and encounter conditions to support them. Two entries have been added to the pokemon table to support the female version of jellicent and frillish, since this alternative form wasn't in that table yet for some reason.
75,9,story-progress-juniper-cave-of-being,0 | ||
76,11,item-lunar-wing,0 | ||
77,9,story-progress-quake-badge,0 | ||
78,11,item-light-stone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we can this error in the CI:
UNIQUE constraint failed: pokemon_v2_encounter.id
I don't think it's releated to this file, but in this file maybe it's worth adding the trailing ,0
at lines 78-81
Also there's a small edge case I wanted to discuss: |
Hmm, but I think that Jellicent in reality has two genders only, right? Male and female? There's no neutral I think. So I think we encountered another limitation due to how the data is structured in our API. |
It does but most encounters can result in either male or female, while some special encounters are forced into one or the other, the same can happen in other encounters (say unown) |
Added Special encounters for gens 5-7 along with necessary additional encounter conditions and location areas. Also a new encounter slot for OR AS Devon Scope
This can be merged now |
Missing special encounters from gens 6 and 7 are numerous and complex, may be adding them in the near future if I can get around to it.