Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed connection hang, segfault, and unexpected warnings issues after internet connection loss. #60

Merged
merged 41 commits into from
Mar 29, 2024

Commits on Mar 25, 2024

  1. Don't increment the max reconnect counter for socket errors.

    This counter is intended to detect possible authentication issues (e.g.,
    incorrect key). Socket errors, typically some form of "internet connection not
    available," should not count against that.
    adamshapiro0 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2f1d23d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0626114 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b72f6f5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    518e233 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Configuration menu
    Copy the full SHA
    c1984b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3968f19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bb9a895 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bf10a42 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1beaa5a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    18bdaac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8c5487c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ba48adc View commit details
    Browse the repository at this point in the history
  9. Refactored socket closed check logic to handle 1029 and various warni…

    …ng cases.
    
    The Polaris network now sends an RTCM 1029 text message in response to an
    authentication failure or similar error. The client no longer receives 0 bytes
    when an authentication token is rejected.
    
    This change avoids misleading warnings when authentication is valid but position
    is not supplied, etc. We now return POLARIS_CONNECTION_CLOSED when the
    connection is closed without an authentication error, including if we do not
    receive any data from the network, and only return POLARIS_FORBIDDEN if we
    suspect an authentication issue.
    adamshapiro0 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f32def9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0155d9b View commit details
    Browse the repository at this point in the history
  11. Corrected debug message.

    adamshapiro0 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    965329b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3b5f776 View commit details
    Browse the repository at this point in the history
  13. Formatting cleanup.

    adamshapiro0 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    468edc8 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4989b21 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0132c7e View commit details
    Browse the repository at this point in the history
  16. Check for IPv6 returns in P1_SetAddress().

    The P1_SetAddress() does not currently support IPv6. This may change in the
    future.
    adamshapiro0 committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4b3fa85 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    b4fbd70 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    8cb4095 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    c2d71f2 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    f5e4a63 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    aebad79 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    50a78fd View commit details
    Browse the repository at this point in the history
  2. Statically link ASAN for the benefit of unit test scripts.

    Otherwise, ASAN needs to be manually loaded via LD_PRELOAD.
    adamshapiro0 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    71bf70e View commit details
    Browse the repository at this point in the history
  3. Revert "Remove ssl context variables from Polaris context if compiled…

    … out."
    
    We cannot remove these. Internally, polaris.c accesses them if POLARIS_USE_TLS
    is enabled _when polaris.c is compiled_. But if the user application does not
    set POLARIS_USE_TLS when they compile and instantiate PolarisContext_s, the
    context they create will be smaller than polaris.c is expecting and will cause a
    buffer overflow.
    adamshapiro0 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5aee1be View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    46b221e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5849347 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ce70ea2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a9b55b View commit details
    Browse the repository at this point in the history
  8. Fixed missing socket timeout errno conditions.

    Without these, loss of internet connection could get treated as an unexpected
    socket error, rather than a timeout, and Polaris_Run() might exit its while loop
    and never reconnect.
    adamshapiro0 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c6878bd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    899a4cf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d56e7ef View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    dec6570 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bda0bc0 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    3f38ab4 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Configuration menu
    Copy the full SHA
    8b2d9e0 View commit details
    Browse the repository at this point in the history
  2. Minor review cleanup.

    adamshapiro0 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    c865926 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d1ac61b View commit details
    Browse the repository at this point in the history