Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge pcl_io_ply into pcl_io to resolve #4422 #5628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miriameng
Copy link

No description provided.

@mvieth
Copy link
Member

mvieth commented Mar 12, 2023

Hi, thanks for the pull request. I agree that it makes sense to compile src/ply/ply_parser.cpp into the pcl_io target. However, I would not remove pcl_io_ply yet, since people might link to it (as recommended in the issue), and simply removing it would break their builds. Ideally, we would add some kind of deprecation warning to pcl_io_ply that is displayed when someone tries to use it (link to it), but I currently have no idea how we could do that.
So I would suggest the following: Keep pcl_io_ply unchanged for now, add src/ply/ply_parser.cpp to the sources of pcl_io, and also keep PCL_ADD_INCLUDES(...) (because otherwise, projects using PCL won't find those ply headers).

@mvieth mvieth added module: io changelog: fix Meta-information for changelog generation labels Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants