Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

585 Fix deprecated Behat steps #586

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

leonstr
Copy link
Contributor

@leonstr leonstr commented Jul 26, 2024

Update Behat tests replacing steps deprecated by MDL-79029.

Proposed fix for #585

Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Can you rebase with the latest MOODLE_401_STABLE to re-enable the CI tests?

@leonstr
Copy link
Contributor Author

leonstr commented Aug 22, 2024

Rebased.

@mchurchward
Copy link
Contributor

I don't think you rebased properly. Your PR includes four commits that are not part of your work. Can you make sure you pull the latest questionnaire MOODLE_401_STABLE branch and then rebase your commit on top of that? That should fix your PR.

Update Behat tests replacing steps deprecated by MDL-79029.
@leonstr
Copy link
Contributor Author

leonstr commented Aug 28, 2024

Hopefully this has been rebased correctly now.

@mchurchward mchurchward merged commit a581289 into PoetOS:MOODLE_401_STABLE Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants