Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt icon size to 24×24 with a smaller content as other icons. #569

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Adopt icon size to 24×24 with a smaller content as other icons. #569

merged 1 commit into from
Aug 28, 2024

Conversation

lucaboesch
Copy link
Contributor

This resolves #568

mchurchward
mchurchward reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this icon still look okay on earlier Moodle 4 versions?

@mchurchward
Copy link
Contributor

Also, please rebase with the latest MOODLE_401_STABLE.

@lucaboesch
Copy link
Contributor Author

Rebased and only one commit diff, @mchurchward !
It will look okay on elder versions.

mchurchward
mchurchward approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mchurchward mchurchward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mchurchward mchurchward merged commit 81c026d into PoetOS:MOODLE_401_STABLE Aug 28, 2024
4 of 5 checks passed
@lucaboesch lucaboesch deleted the iconsize branch August 29, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchurchward mchurchward mchurchward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New monologo activity icon for Moodle 4.4
2 participants
@lucaboesch @mchurchward