Allow questionnaire to be gradable LTI advantage activity #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was changed due to the tracker CONTRIB-4274 report. Can you review there and confirm that this does not cause a regression? |
|
Good find: I will put that on my to-do list and see what happens when following that procedure. |
mchurchward
force-pushed
the
MOODLE_401_STABLE
branch
from
6253d1a
to
3309603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2013, the FEATURE_GRADE_HAS_GRADES was toggled to False without comment. This makes the questionnaire activity ineligible to send grades when using Moodle as an LTI 1.3 Tool, among other potential effects. Additionally, the grade line item isn't created when a questionnaire is initially added to a course in spite of that initial configuration allowing it to be graded; the line item is, however, added when the activity configuration is re-saved without making changes.