Questionnaire different ≤ 4.2 and ≥ 4.3 activity completion behat tests …

[lucaboesch]

… fix #522 .

Dear @mchurchward this pull request lets pass the automated tests again.

Best,
Luca

[rezeau]

Just tested this PR on my local Moodle site running Moodle 4.3. PR Works as expected, the first scenario (Check questionnaire completion feature in web for Moodle ≤ 4.2) is skipped and the "Check questionnaire completion feature in web for Moodle ≥ 4.3" scenario is passed OK.
A very minor grievance: I am running those behat tests on my Windows box, with profile=geckodriver and the test begins to show in an Acceptance text site window but, when scenario 1 is skipped, then that window closes and does not re-open. However, if I add the --format=pretty parameter I can follow all the steps in my Windows shell window, so that's OK.

[mchurchward]

@lucaboesch thanks for this. Do you know why we need to add "xpath" for 4.3? This seems to be something that would not be desirable.

[lucaboesch]

And I click on "3" radio wouldn't execute any more, @mchurchward, I tried it...

[mchurchward]

But it does work in other places, like:

• add_feedback.feature
• add_multi_feedback_with_sections.feature

That makes me think there is something wrong with the display of that radio. There may need to be a fix in the display code.

[mchurchward]

Also, the error that was highlighted here was for "Completion tracking". So the radio error came up after that was fixed?

[mchurchward]

@lucaboesch I just tested this locally, and the only change it needs is for the "Completion tracking". The radio buttons work fine.

[lucaboesch]

It would be of great help if you could paste in the modified lines here, @mchurchward

[lucaboesch]

I had it run again.
The Moodle Plugin CI run error states

001 Scenario: Check questionnaire completion feature in web for Moodle ≥ 4.3. # /home/runner/work/moodle-mod_questionnaire/moodle-mod_questionnaire/moodle/mod/questionnaire/tests/behat/questionnaire_activity_completion.feature:70
      And I click on "Yes" "radio"                                            # /home/runner/work/moodle-mod_questionnaire/moodle-mod_questionnaire/moodle/mod/questionnaire/tests/behat/questionnaire_activity_completion.feature:111
        Behat\Mink\Exception\UnsupportedDriverActionException: Behat\Mink\Driver\BrowserKitDriver supports clicking on links and submit or reset buttons only. But "input" provided in /home/runner/work/moodle-mod_questionnaire/moodle-mod_questionnaire/moodle/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:468

[mchurchward]

I think the lines below can be simplified to:

And I expand all fieldsets
And I set the following fields to these values:
  | Add requirements                                      | 1 |
  | Student must submit this questionnaire to complete it | 1 |

This is from examples in core.

[mchurchward]

The code:
And I click on "Yes" "radio"
And I click on "Three" "radio"
still works for me running Behat locally. I don't think this and the next change are needed.

[mchurchward]

I wonder if its due to "master". The CI should be changed to MOODLE_403_STABLE now that it has been released.

[mchurchward]

I had it run again. The Moodle Plugin CI run error states

001 Scenario: Check questionnaire completion feature in web for Moodle ≥ 4.3. # /home/runner/work/moodle-mod_questionnaire/moodle-mod_questionnaire/moodle/mod/questionnaire/tests/behat/questionnaire_activity_completion.feature:70
      And I click on "Yes" "radio"                                            # /home/runner/work/moodle-mod_questionnaire/moodle-mod_questionnaire/moodle/mod/questionnaire/tests/behat/questionnaire_activity_completion.feature:111
        Behat\Mink\Exception\UnsupportedDriverActionException: Behat\Mink\Driver\BrowserKitDriver supports clicking on links and submit or reset buttons only. But "input" provided in /home/runner/work/moodle-mod_questionnaire/moodle-mod_questionnaire/moodle/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:468

I wonder if that is a Chrome issue with Behat? Maybe try changing the CI behat line:
run: moodle-plugin-ci behat
(drop the --profile chrome part)?

[mchurchward]

@lucaboesch I figured out the problem. Radio buttons should not use "I click". They need a "Set field to" instead. But, they do work if "@javascript" is specified, and it wasn't for the new 4.3 scenario. In any case, the correct fix is to use "set field to".
See my commit here. It does the "set field" and additionally I simplified the scenarios by moving the duplicate steps to the background. If you want to update your PR accordingly, I will merge it in.

[lucaboesch]

Yeah, @mchurchward, but the point was to make the test passing for Moodle ≥ 4.3 as well as Moodle ≤ 4.2 so you don't resolve in leaving out those versions in ci.yml.
This updated pull request fits all needs and supports PHP 7.4, 8.0 and 8.1.

Best,
Luca

[mchurchward]

Thanks Luca. Of course once we add PHP8.2 to the CI, there will be a huge mess. :-0