Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add battery icon to powerbutton menu #16

Closed
wants to merge 1 commit into from

Conversation

rorosaurus
Copy link
Contributor

Adds a tiny battery icon to the powerbutton menu.

@Spritetm are there concerns about importing ugui and widgets here, to maximize resources available to the other apps?

@rorosaurus
Copy link
Contributor Author

Related: PocketSprite/8bkc-chooser#18

@Spritetm
Copy link
Collaborator

So, errm... I don't think this actually works in most cases :) The issue is that the powerbutton menu doesn't necessarily use the same framebuffer as ugui does. If it happens to do (e.g. when you're in an ugui widget and press the power button, and the code uses ugui's frame buffer), the writes will go to the correct framebuffer and everything will work. However, if you, say, have a tilegfx-based framebuffer, the entire thing will either not show or horribly crash.

@rorosaurus
Copy link
Contributor Author

Ah, okay! I only tested it with the chooser.app and otacon's hello.app, so it makes sense that I would have missed the tilegfx scenario... Good to know! I guess what I'd need to do is create a solution that works for both cases, by avoiding the ugui calls. I'll look closer at how the buttons are rendered in the powerbutton menu.

@rorosaurus
Copy link
Contributor Author

Aborting this branch, see #18

@rorosaurus rorosaurus closed this Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants