HDMA should not start during HBLANK. Fixes Donkey Kong Country. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried this fix on my gnuboy fork and Extreme Ghostbusters & Killer Instinct still work fine.
|
I compiled this and I can confirm that it fixed the problem on real hardware. No regressions noticed yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So while i was working on my own Gnuboy fork and tried to merge an upstream fix for Killer Instinct,
i broke DKC.
After some testing, i've found that disabling this exact line fixed the game while still allowing Killer Instinct & Extreme Ghostbusters to work.
Upstream also had a note with it basically saying that it was probably not needed... really.
As soon as it was disabled, Donkey Kong Country started to work without glitchy graphics ingame.