Fix monitoring warning TBaseVisits.dataset... #2773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2773 +/- ##
===========================================
- Coverage 78.43% 68.56% -9.87%
===========================================
Files 88 86 -2
Lines 7183 7435 +252
===========================================
- Hits 5634 5098 -536
- Misses 1549 2337 +788
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Need to add foreign key in order to delete visit object Reviewed-by: andriacap
Needed to add observers_txt same as OCCTAX to let the user to choose between observers list or observers_txt in observation form. Reviewed-by: andriacap
Add revision alembic Reviewed-by: andriacap
Reviewed-by: andriacap
Reviewed-by: andriacap
amandine-sahl
force-pushed
the
fix/gn_monitoring_warning
branch
from
0a7f609
to
f8ffd9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppression du message
SAWarning: Property TBaseVisits.dataset on mapped class TBaseVisits->t_base_visits being replaced with new property TBaseVisits.dataset; the old property will be discardedcf PnX-SI/gn_module_monitoring#225
A intégrer avec PnX-SI/gn_module_monitoring#256