Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synthese) fix pin not working #2702

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix(synthese) fix pin not working #2702

merged 1 commit into from
Sep 15, 2023

Conversation

Pierre-Narcisi
Copy link
Contributor

@Pierre-Narcisi Pierre-Narcisi commented Sep 14, 2023

Fix #2507

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage is 80.00% of modified lines.

Files Changed Coverage
backend/geonature/core/gn_synthese/routes.py 80.00%

📢 Thoughts on this report? Let us know!.

@camillemonchicourt camillemonchicourt added this to the 2.13 milestone Sep 15, 2023
@camillemonchicourt camillemonchicourt merged commit bc7fc54 into develop Sep 15, 2023
9 of 10 checks passed
@camillemonchicourt camillemonchicourt deleted the fix/pin branch September 15, 2023 09:45
@mvergez
Copy link
Contributor

mvergez commented Sep 15, 2023

Salut !

C'est dommage ces lignes ajoutées ne sont pas couvertes par un test :
https://github.com/PnX-SI/GeoNature/pull/2702/files#diff-5fb8d19676b01cc7c0b77799d74e25c6a6ff510372180a633a2ecd1682c3c4d9R1122-R1123

Cette PR fait donc baisser le coverage. Ce n'est pas grave en soi car c'est juste 0.01% mais il faut quand même faire attention de ne pas faire ça sur toutes les PR sachant que le coverage total n'est pas super haut.

@camillemonchicourt
Copy link
Member

Ouais mais y avait des tests mais l'épinglage ne fonctionnait pas...
Tous les utilisateurs voyaient les épinglages des autres utilisateurs...

@camillemonchicourt
Copy link
Member

Pour les tests dont la couverture baissait avec cette PR, c'est remonté par ailleurs pour ne pas laisser comme ça ;-)
https://github.com/PnX-SI/GeoNature/pull/2712/files#diff-60d84cf6fb7a049fa3a2bab228c7abb3553f96d3fccb8b5c60c3a1fc0f03ffaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants