-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multiple photos #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base while designing app and a dataCleaner file to shave off excess data from the fetch calls. Also update Fact.js to work with the new data set and update functions for favoriting and unfavoriting cat facts
…er effect on the nav bar in the header
…es -FactCard.js- and -FactCard.css-
…logic to changin the displayed fact
…d functionality for de-activated back arrow if there is nothing preceeding the current cat fact
…ning which are triggering fetch calls, this needs to be addressed next
…ir corresponding details
… to be rendered while the application fetches more data
…move commented out code and console.logs
…d id instead of creating new id's
… to delete a favorite from the fact card
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will update the whole application. Changes have been made to the entire aesthetic of the application. This is mostly due to changing to an api that returns more data with each fetch. Now the app is getting a large amount of data with each call that includes unique photos. Changes have been made to showcase this data. Which includes more styling and responsive layouts. Cypress tests have also been updated to accommodate the new data being handled.