Feature/cypress #24
Merged
Feature/cypress #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re is no existing fact in session storage
…tree and update the error test suit to reflect recent changes to the error page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request features updates to the cypress error tests to reflect the new catch all error message page. Along with that, the error page has been set at the top of the component tree using the errorElement route. I also removed the error state and any lines of code within the application that updated the state because I was using that state to conditionally render the Error component but errorElement route eliminated that need. I also fixed the bug that continued to generate new random facts when the user favorited a fact AND there were no facts saved in session storage at the time.