Partial out-of-the-box build support #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the POM file and includes jar files for almost all the required libaries. This allows other contributors to be able to clone the repository and build from Maven or IDE without issues. Changes made: * Included required jar files as a local Maven repository (see http://randomizedsort.blogspot.co.uk/2011/10/configuring-maven-to-use-local-library.html ) * Removed Spout repo and dependency (unused, broken) * Changed minimum code level to Java 1.7 (fixes IDE error with @OverRide in interfaces) * Fixed version variable in generated JAR manifest Note: TuxTwoLib has been left out until it is ready for distribution, as per Tux2's wishes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is, MultiInv is impossible to build from a cloned repository. This is because of missing required libraries and missing POM file entries. This makes it difficult for people to contribute changes and bug fixes.
This PR fixes the POM file and includes jar files for almost all the required libraries. This allows other contributors to be able to clone the repository and build from Maven or IDE without issues.
Changes
@Overridein interfaces)Testing
mvn clean packageConsiderations
mvn install:install-file -Dfile=path/to/TuxTwoLib.jar -DgroupId=Tux2.TuxTwoLib -DartifactId=TuxTwoLib -Dversion=bBUILDNUMBERHERE -Dpackaging=jar -DlocalRepositoryPath=lib<version>b7</version>tag inpom.xmlfor TuxTwoLib