Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename relative_margin to relativeMargin for consistency #95

Merged

Conversation

nicoddemus
Copy link
Contributor

Follow up to 0e44c89, I noticed the new parameter name relative_margin does not follow the naming scheme used by the other parameters in the library, so renamed it to relativeMargin.

Relative to #94.

Follow up to 0e44c89, I noticed the new parameter name `relative_margin` does not follow the naming scheme used by the other parameters in the library, so renamed it to `relativeMargin`.
@nicoddemus
Copy link
Contributor Author

nicoddemus commented Jan 2, 2025

Btw I realize PythonQwt already has a testing setup/framework in-place, just wanted to mention that there's pytest-qt (I'm one of the maintainers) which provides facilities to test Qt code. 👍

Copy link
Collaborator

@PierreRaybaut PierreRaybaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're perfectly right.

@PierreRaybaut
Copy link
Collaborator

Btw I realize PythonQwt already has a testing setup/framework in-place, just wanted to mention that there's pytest-qt (I'm one of the maintainers) which provides facilities to test Qt code. 👍

Thanks for pointing that out.
Actually, we did test it a while ago but we choose to not depend on it, first to limit the dependencies to the strict minimum, second because we had issues or we encountered some limitations (not on PythonQwt but on PlotPy) but I don't remember what exactly (not very constructive, I'm sorry).

@PierreRaybaut PierreRaybaut merged commit fbae8a2 into PlotPyStack:master Jan 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants