Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scale field from PanOrbitCamera #58

Merged
merged 2 commits into from Feb 24, 2024
Merged

Remove scale field from PanOrbitCamera #58

merged 2 commits into from Feb 24, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2024 •
edited by Plonq
Loading

Closes #57

I've added an example of switch projection to the orthographic example

App.2024-02-23.22-09-58.mp4

Plonq
Plonq requested changes Feb 24, 2024
View reviewed changes
Copy link
Owner

@Plonq Plonq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm all for simplifying things, and I like the clipping prevention too.

Can you please address the one minor comment and then it's ready to merge

examples/orthographic.rs Outdated Show resolved Hide resolved
@Plonq Plonq merged commit b0d92ec into Plonq:master Feb 24, 2024
5 checks passed
@Plonq
Copy link
Owner

Plonq commented Feb 24, 2024

Thanks!

@Plonq Plonq mentioned this pull request Mar 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove scale field?
2 participants
@Plonq @kumikaya