Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leak when using EditorCoroutine.cs #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Dec 17, 2022

  1. Fixed memory leak when using EditorCoroutine.cs

    Fixed memory leak issue, caused by the EditorCoroutine class not disposing the web request after.
    
    ```
    A Native Collection has not been disposed, resulting in a memory leak. Allocated from:
    Unity.Collections.NativeArray`1:.ctor(Byte[], Allocator)
    UnityEngine.Networking.UploadHandlerRaw:.ctor(Byte[])
    PlayFab.PfEditor.PlayFabEditorHttp:MakeApiCall(String, String, GetTitleDataRequest, Action`1, Action`1) (at Assets\PlayFabEditorExtensions\Editor\Scripts\PlayFabEditorSDK\PlayFabEditorHttp.cs:85)
    PlayFab.PfEditor.PlayFabEditorApi:GetTitleInternalData(Action`1, Action`1) (at Assets\PlayFabEditorExtensions\Editor\Scripts\PlayFabEditorSDK\PlayFabEditorApi.cs:69)
    PlayFab.PfEditor.TitleInternalDataViewer:RefreshInternalTitleData() (at Assets\PlayFabEditorExtensions\Editor\Scripts\Components\TitleInternalDataViewer.cs:123)
    PlayFab.PfEditor.TitleInternalDataViewer:Draw() (at Assets\PlayFabEditorExtensions\Editor\Scripts\Components\TitleInternalDataViewer.cs:28)
    PlayFab.PfEditor.PlayFabEditorDataMenu:DrawDataPanel() (at Assets\PlayFabEditorExtensions\Editor\Scripts\Panels\PlayFabEditorDataMenu.cs:52)
    PlayFab.PfEditor.PlayFabEditor:OnGuiInternal() (at Assets\PlayFabEditorExtensions\Editor\PlayFabEditor.cs:146)
    PlayFab.PfEditor.PlayFabEditor:HideRepaintErrors(Action) (at Assets\PlayFabEditorExtensions\Editor\PlayFabEditor.cs:184)
    PlayFab.PfEditor.PlayFabEditor:OnGUI() (at Assets\PlayFabEditorExtensions\Editor\PlayFabEditor.cs:116)
    UnityEditor.HostView:InvokeOnGUI(Rect)
    UnityEditor.DockArea:DrawView(Rect)
    UnityEditor.DockArea:OldOnGUI()
    UnityEngine.UIElements.IMGUIContainer:DoOnGUI(Event, Matrix4x4, Rect, Boolean, Rect, Action, Boolean)
    UnityEngine.UIElements.IMGUIContainer:HandleIMGUIEvent(Event, Matrix4x4, Rect, Action, Boolean)
    UnityEngine.UIElements.IMGUIContainer:HandleIMGUIEvent(Event, Action, Boolean)
    UnityEngine.UIElements.IMGUIContainer:HandleIMGUIEvent(Event, Boolean)
    UnityEngine.UIElements.IMGUIContainer:SendEventToIMGUIRaw(EventBase, Boolean, Boolean)
    UnityEngine.UIElements.IMGUIContainer:SendEventToIMGUI(EventBase, Boolean, Boolean)
    UnityEngine.UIElements.IMGUIContainer:HandleEvent(EventBase)
    UnityEngine.UIElements.CallbackEventHandler:HandleEventAtTargetPhase(EventBase)
    UnityEngine.UIElements.MouseCaptureDispatchingStrategy:DispatchEvent(EventBase, IPanel)
    UnityEngine.UIElements.EventDispatcher:ApplyDispatchingStrategies(EventBase, IPanel, Boolean)
    UnityEngine.UIElements.EventDispatcher:ProcessEvent(EventBase, IPanel)
    UnityEngine.UIElements.EventDispatcher:ProcessEventQueue()
    UnityEngine.UIElements.EventDispatcher:OpenGate()
    UnityEngine.UIElements.EventDispatcherGate:Dispose()
    UnityEngine.UIElements.EventDispatcher:ProcessEvent(EventBase, IPanel)
    UnityEngine.UIElements.EventDispatcher:Dispatch(EventBase, IPanel, DispatchMode)
    UnityEngine.UIElements.BaseVisualElementPanel:SendEvent(EventBase, DispatchMode)
    UnityEngine.UIElements.UIElementsUtility:DoDispatch(BaseVisualElementPanel)
    UnityEngine.UIElements.UIElementsUtility:UnityEngine.UIElements.IUIElementsUtility.ProcessEvent(Int32, IntPtr, Boolean&)
    UnityEngine.UIElements.UIEventRegistration:ProcessEvent(Int32, IntPtr)
    UnityEngine.UIElements.<>c:<.cctor>b__1_2(Int32, IntPtr)
    UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)
    ```
    GammaFoxTBG committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    3344ec3 View commit details
    Browse the repository at this point in the history