Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platzi Master Felipe Duitama #61

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

felipedc09
Copy link

@felipedc09 felipedc09 commented May 19, 2021

Steps #6

  • I reviewed the project and understod the structure including configutarioins and tests.
  • I created dummy components to pass the tests.
  • I don't like repeate code in other components so I created general or atomic components to use in others compones as Box and ListItem, this encapsulation included the styles.
  • I completed the getData funtion to pass test y had to add a regenerator-runtime dependencie to run async functions in components.
  • I made public a service in Heroku to get curriculum data with the example and my personal data, I used this service to set curriculum data to the compoenents and show my curriculum customized.
  • I modified the test to use json data example passing the testing
  • I didn't changs much more the propused styles because I'll think make some powerfull this project, creating my CV in PDF with styles but this is complex, and make an interactive interface to change colors, and font sizes or other properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant