Initial cleanup #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unable to get rspec to pass after adding the i18n file |
|
Skipped "spec/system/homepage_spec.rb: from https://github.com/Platoniq/decidim-inspire/pull/4/files, unsure which version of this file we want in this repo. |
fblupi
requested changes
Jun 27, 2024
There was a problem hiding this comment.
I asked @rxnetwalker and he told me the EU logo should not be included in this project.
You should not include the public/sw.js* files. Please remove them from this PR and change the .gitignore to ignore those files so it won't happen again.
fblupi
approved these changes
Jun 27, 2024
fblupi
added a commit
that referenced
this pull request
Jul 1, 2024
* initial commit * add figaro * add passsenger * Linting and specs (#3) * Added .github/workflow file for CI * Lint ERB files with erblint * Lint SCSS files with stylelint * Add i18n spec * Lint JS files with eslint * Lint MarkDown files with mdl * Default local to :ca * Rubocop automatic fixes * db:migrate to create db/schema.rb * Revert "Default local to :ca" This reverts commit 00532b0. * Run Rubocop * Rubocop corrections * Restored db/migrate files to before rubocop fixes * Remove config/deploy symlink and fix .gitignore * Initial cleanup (#4) * Add GH CI result to README.md * Ignore .rspec-failures * i18n spec file * homepage and other spec files * Remove test directory * Fix README rubocop suggestion * i18n_spec to english * default locale to :ca, edit en.yml * Platoniq and EU logos in footer * More spec files to go with the new footer * Edited expected checksum in overrides_spec.rb * remove eu logo * public.sw.js* in .gitignor * Remove cached ublic/sw.js* files * correct platoniq footer spec * Remove lingering EU footer files * default locale to :en to be overwritten with env variable * Add decidim awesome (#5) * Add GH CI result to README.md * Ignore .rspec-failures * i18n spec file * homepage and other spec files * Remove test directory * Fix README rubocop suggestion * i18n_spec to english * default locale to :ca, edit en.yml * Platoniq and EU logos in footer * More spec files to go with the new footer * Edited expected checksum in overrides_spec.rb * Add decidim awesome * db:migrate for rspec failing * add decidim awesome to gemfile and run webpack install for decidim awesome * decidim_awesome spec file * update decidim dev packages to correct version * remove eu-logo.png * default locale to :en * remove eu.en.yml * Remove cached public/sw.js* files * remove eu_footer_spec.rb * Add decidim awesome factories --------- Co-authored-by: Fran Bolívar <[email protected]> * Update README.md * Move .erb-lint.yml --------- Co-authored-by: David Igón <[email protected]> Co-authored-by: Harrison Hassig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homepage spec
Factories spec
rails helper spec
spec helper
Remove test/ directory