Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include leaflet import only when no here maps provider is configured #34

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Oct 2, 2023

Fixes #33

Screen.Recording.2023-10-02.at.15.28.41.mov

@fblupi fblupi added the bug Something isn't working label Oct 2, 2023
@fblupi fblupi requested a review from rxnetwalker October 2, 2023 13:33
@fblupi fblupi assigned davidbeig and unassigned davidbeig Oct 2, 2023
@fblupi fblupi requested a review from davidbeig October 2, 2023 13:33
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (42479d2) 82.60% compared to head (52c6b36) 82.60%.
Report is 1 commits behind head on main.

❗ Current head 52c6b36 differs from pull request most recent head c899874. Consider uploading reports for the commit c899874 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files          28       28           
  Lines         460      460           
=======================================
  Hits          380      380           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fblupi fblupi merged commit 13cb664 into main Oct 2, 2023
3 checks passed
@fblupi fblupi deleted the fix/33 branch October 2, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error rendering navigation maps in a page with other maps
3 participants