Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single LinearConstraintProjection in ProximalProjection #1409

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YigitElma
Copy link
Collaborator

For now, just a discussion for the appropriate API.

  • Maybe add a _eq_solve_objective property to ProximalProjection which will be LinearConstraintProjection of ForceBalance and fixed boundary constraints.
  • Only update the fixed parameter constraint targets of _eq_solve_objective, and calculate particular solution without factorization
  • Pass _eq_solve_objective to eq.perturb and eq.solve?

Resolves #1404

@dpanici
Copy link
Collaborator

dpanici commented Nov 27, 2024

Add kwarg eq.solve which takes in LinearConstraintProjection called linear_constraint, which gets passed in through options of optimizer.optimize and from there it will skip necessary builds etc

@YigitElma YigitElma self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't call factorize_linear_constraint every time in _update_equilibrium of ProximalProjection?
2 participants