Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:close-navmenu-outside #601

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

URVESH1121
Copy link

Description 📝

Fixes/Closes: #600

Please provide a brief description of the purpose and goals of this pull request.

  • When user click outside the navmenu then navmenu will be close

Screenshots (if applicable)

Loom.Message.-.25.August.2023.mp4

@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gyanaguru ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 11:57am

Copy link

@lalitmee lalitmee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if we can do the closing without using addEventListener

@URVESH1121
Copy link
Author

@lalitmee , I've submitted a pull request (#601) with some changes. Could you please take a look and let me know your thoughts? Your feedback would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Navmenu for mobile does not close on clicking outside of menu
2 participants