Added the ability to customize the result container instead of appending directly to the body. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var rect = that.getBoundingClientRect(); | ||
| that.sc.style.left = Math.round(rect.left + (window.pageXOffset || document.documentElement.scrollLeft) + o.offsetLeft) + 'px'; | ||
| that.sc.style.top = Math.round(rect.bottom + (window.pageYOffset || document.documentElement.scrollTop) + o.offsetTop) + 'px'; | ||
| that.sc.style.width = Math.round(rect.right - rect.left) + 'px'; // outerWidth |
There was a problem hiding this comment.
I think it's still beneficial to set width when using a non-body container.
|
Can we merge this PR if/when any issues are resolved? Being able to set your own container if you want, is useful and it would be great to have it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifically works for me in a situation where I have a fixed header, but I realized that sometimes people scroll while the results are still visible. This means that the results end up staying positioned absolutely in the page, while the search bar moves around because it's fixed. So, I added in the ability to add a "container" option where you pass a selector in and the results are then appended there instead of the body. Default functionality still applies if you don't add any selections. I've also added another class if you do define the result set, so that you can add CSS to remove the position absolute if you need to.