Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic functionality for ijai map acquisition and image rendering #527

Open
wants to merge 9 commits into
base: dev_extracted_libraries
Choose a base branch
from

Conversation

Tarh-76
Copy link

@Tarh-76 Tarh-76 commented Apr 13, 2024

No description provided.

@PiotrMachowski
Copy link
Owner

Hi @Tarh-76, thank you for your contribution!
There's just one problem: at this moment the latest development version of the integration is on dev_extracted_libraries branch. On this branch map parsing has been extracted to appropriate libraries. Would you like to do the same for Ijai vacuums?

@Tarh-76
Copy link
Author

Tarh-76 commented Apr 14, 2024

Hi @Tarh-76, thank you for your contribution! There's just one problem: at this moment the latest development version of the integration is on dev_extracted_libraries branch. On this branch map parsing has been extracted to appropriate libraries. Would you like to do the same for Ijai vacuums?

Hi Piotr,
Thanks for the advice, sounds like a plan to me. Do I get it right that to follow it I should rebase my branch to dev_extracted_libraries branch? The thing is I'm kinda new to GitHub and may ask some not-so-smart questions.

@PiotrMachowski PiotrMachowski changed the base branch from master to dev_extracted_libraries April 14, 2024 14:17
@PiotrMachowski
Copy link
Owner

You can try to rebase it, but it might be quite hard (there are a lot of conflicts), so it might be easier to create a branch from dev_extracted_libraries and move your changes there manually. Also you would have to create a pip library that will contain map parser for Ijai vacuums (similarly to approach used here).

…tialization of Palette

and ImageConfig objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants