New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local refactorings in `AddNoiseEffect` #623

Merged

cameronwhite merged 2 commits into PintaProject:master from Lehonti:improvement1

Dec 20, 2023

Contributor

Lehonti commented Dec 20, 2023 •

edited

Loading

Created AddNoiseSettings, for consistency with other effects, but also to get the reference to Data.Seed out of the foreach loop. From previous (subjective) experience, casting the EffectData object every time slows down the rendering noticeably.
Removed a nesting level by getting rid of an else block. I think it's still clear enough
Reduced variable reassignment inside for loop

Lehonti added 2 commits

December 20, 2023 01:42


          Local refactorings in AddNoiseEffect

f899f06


          Created settings object

0f80bdd

cameronwhite merged commit ee146dc into PintaProject:master

5 checks passed

Lehonti deleted the improvement1 branch

December 20, 2023 09:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet