Re-enable the Windows installer for GTK4 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Windows the plan is to copy the MSYS GTK libs to the build folder so Pinta can be easily launched without manipulating the path, so this is most easily done by adding sibling `lib` and `share` folders. This doesn't affect the output of 'dotnet publish', so the existing Linux and macOS install scripts should still work.
This allows Pinta to successfully run without MSYS in the path.
- The CI machines seem to have MinGW installed under a non-standard prefix, so this also must be overridden
- Avoid warning from using the -o parameter when publishing - Merge the locale folders, in addition to icons - Revert changes to the icon lookup path, which weren't actually necessary since the bundled GTK libraries include `../share` in their search path automatically - Fix missing libraries from the latest MSYS packages
Similar to the macOS installer, we need to update the index.theme to include the expected folders.
This avoids having an existing `icon-theme.cache` for the `hicolor` theme which is out of date vs the updated index.theme we install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildfolder, rather than justbin. This allows copying the GTK library dependencies to siblingshareandlibfolders.