Supersampling for smoother Voronoi diagrams #1128
Open
+90
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here
We would be (at least temporarily) sacrificing the feature of viewing where the control points are, but I think that's fine.
For some reason, this has made the effect slow (kind of like Mandelbrot) so in the last three commits I made the effect tileable, which comes at the cost of re-computing the settings, but the user gets some live feedback. Still, I envision it improving a lot after the refactoring of the rendering mechanism is complete.
The implementation of the supersampling is 'naive' in that it doesn't take into account the large solid regions. I'd need to think how to optimize this and/or the matching of locations to the closest control point (perhaps by using an R-Tree?), but I think that's better left for a future pull request. There's only so much that can be achieved with the current tileability mechanism.