feat(picqer): dont handle hook when ordercode is not found

Pinelab-studio · Jul 31, 2023 · 7d86fd6 · 7d86fd6
1 parent 2cf05eb
commit 7d86fd6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml
@@ -1,16 +1,9 @@
 name: Publish packages
 
 on:
-  workflow_dispatch:
-    inputs:
-      version:
-        type: choice
-        description: What version do you want to publish?
-        required: true
-        options:
-          - patch
-          - minor
-          - major
+  push:
+    branches:
+      - main
 
 jobs:
   Publish:

diff --git a/packages/vendure-plugin-picqer/src/api/picqer.service.ts b/packages/vendure-plugin-picqer/src/api/picqer.service.ts
@@ -357,7 +357,11 @@ export class PicqerService implements OnApplicationBootstrap {
       'lines.productVariant',
     ]);
     if (!order) {
-      throw new Error(`No order found for code ${data.reference}`);
+      Logger.error(
+        `No order found for code ${data.reference}. Not processing this hook any further`,
+        loggerCtx
+      );
+      return;
     }
     const orderLinesToFulfill: OrderLineInput[] = [];
     data.products.forEach((pickListProduct) => {